Skip to content

clean up legacy statistics function implementation from backend #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2024
Merged

clean up legacy statistics function implementation from backend #2114

merged 3 commits into from
Oct 17, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Oct 16, 2024 •
edited
Loading

Cleaned up legacy statistics function (cov, mean, max, min, std, var, nanvar, count_nonzero) implementation from the backend for speed up build and improve code coverage.

Legacy implementation of sqrt is also removed since it was only used in legacy std.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review October 16, 2024 15:50
antonwolfy
antonwolfy approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana a lot for clean up the code.

@vtavana vtavana merged commit 89b03eb into master Oct 17, 2024
46 checks passed
@vtavana vtavana deleted the clean-legacy-statistics branch October 17, 2024 12:25
github-actions bot added a commit that referenced this pull request Oct 17, 2024
@github-actions
clean up legacy statistics function implementation from backend (#2114)
0ba6a7c 
* clean up legacy statistics

* remove cov from dpnp_iface.hpp

* clean up legacy sqrt 89b03eb
vtavana added a commit that referenced this pull request Oct 28, 2024
@vtavana
clean up legacy statistics function implementation from backend (#2114)
728af7e 
* clean up legacy statistics

* remove cov from dpnp_iface.hpp

* clean up legacy sqrt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy