clean up legacy implementation form backend #2115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtavana
force-pushed
the
clean-legacy-backend
branch
from
35155b5 to
20abff0
Compare
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
requested review from
antonwolfy,
npolina4 and
vlad-perevezentsev
as code owners
antonwolfy
reviewed
Oct 18, 2024
antonwolfy
approved these changes
Oct 18, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2024
* clean up legacy statistics * remove cov from dpnp_iface.hpp * clean up legacy sqrt * clean up legacy backend * remove functions from dpnp/backend/src/dpnp_utils.hpp a374258
vtavana
added a commit
that referenced
this pull request
Oct 28, 2024
* clean up legacy statistics * remove cov from dpnp_iface.hpp * clean up legacy sqrt * clean up legacy backend * remove functions from dpnp/backend/src/dpnp_utils.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up legacy implementation of the following functions: argmin, argmax, argsort, searchsort, sum, prod
Note that legacy
multiplyis used by legacydotwhich is used incorrelate, so legacymultiplyanddotcannot be removed.In addition, legacy
sortis used bymedianand cannot be removed at this time.