-
Notifications
You must be signed in to change notification settings - Fork 22
Add tests folder to dpnp conda package #2116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/pull/2116/index.html |
antonwolfy
reviewed
Nov 7, 2024
antonwolfy
reviewed
Nov 7, 2024
antonwolfy
reviewed
Nov 7, 2024
antonwolfy
reviewed
Nov 7, 2024
antonwolfy
reviewed
Nov 7, 2024
antonwolfy
reviewed
Nov 14, 2024
antonwolfy
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more comments from me.
Thank you @vlad-perevezentsev for the effort to complete that huge improvement.
github-actions bot
added a commit
that referenced
this pull request
Nov 15, 2024
* Move tests to dpnp folder * Update import paths for dpnp tests * Update paths in skipped_tests files * Update import paths in tests_perf * Update import paths in cupy/testing * Update import paths in all cupy tests * Update tests path in pyproject.toml * Remove MANIFEST.in * Add tests folder to conda package * Simplify meta.yaml: move test logic to run_test.sh * Move pytest config from setup.cfg to conftest.py * Update call pytest in gen_coverage.py * Update path to cupy.testing in some tests * Update test paths for github action test_linux * Optimize test skipping and path normalization in conftest.py * Add norecursedirs config for tests_perf in conftest.py * Use relative imports for dpnp tests * Update docs for _loops.py * Add empty __init__.py files to cupy tests * Update import path in test_add_remove.py * Update tests-path for GH Actions * Show extra test summary info in internal CI * Fix normalize_test_name() to support subdirectories * Update normalize_test_name to run pytest from diff paths * Add run_test.bat to conda-recipe * Update pre-commit settings to move tests folder * Use absolute import paths in cupy tests * Update tests path in pyproject.toml * Use package_data instead of data_files in setup.py to pack tests * Update args for generate coverage * Update import path in test_arraypad.py * Rename TEST_SCOPE files to use pytest --pyargs * Remove unused imports in test files * Align import for test_arraypad.py * Use absolute import path in cupy/testing * Print dpnp version while testing conda package * Disable verbose and disable-warnings pytest mode for public CI * Disable quiet, verbose, disable-warnings pytest mode for testing conda package * Remove dublicate env variable MODULE_NAME in conda-package.yaml * Remove working-directory usage for Run tests in conda-package.yml 264c6d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests adding
tests
folder toconda package
andwheel
to enablepytest --pyargs dpnp.tests
commandThe changes contain:
tests
folder to the root of dpnp ( tests -> dpnp/tests)__init__.py
files to run single test files (pytest --pyargs dpnp.tests.third_party.cupy.math_tests.test_arithmatic)As well as other changes related to the move of tests folder (
.flake8
,pre-commit-config.yaml
)