implement dpnp.median
#2117
Merged
implement dpnp.median
#2117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
requested review from
antonwolfy,
npolina4 and
vlad-perevezentsev
as code owners
antonwolfy
reviewed
Oct 21, 2024
antonwolfy
reviewed
Oct 21, 2024
antonwolfy
reviewed
Oct 21, 2024
Co-authored-by: Anton <[email protected]>
antonwolfy
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Thank you @vtavana I have only a small comment to improve test coverage.
github-actions bot
added a commit
that referenced
this pull request
Oct 22, 2024
* implement dpnp.median * use assert_dtype_allclose * add type_check=has_support_aspect64() * address comments * Update dpnp/dpnp_iface_statistics.py Co-authored-by: Anton <[email protected]> * remove a test * add new tests --------- Co-authored-by: Anton <[email protected]> 7c45c10
6 tasks
vtavana
added a commit
that referenced
this pull request
Oct 28, 2024
* implement dpnp.median * use assert_dtype_allclose * add type_check=has_support_aspect64() * address comments * Update dpnp/dpnp_iface_statistics.py Co-authored-by: Anton <[email protected]> * remove a test * add new tests --------- Co-authored-by: Anton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
dpnp.medianis implemented using existing functions in dpnp includingdpnp.sort.