Add support of dpnp.ndindex class
#2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
vtavana
reviewed
Nov 12, 2024
There was a problem hiding this comment.
The documentation shows a few additional methods __eq__, __ne__, etc. Are they relevant? Is it possible to remove them?
https://intelpython.github.io/dpnp/pull/2157/reference/generated/dpnp.ndindex.html#dpnp.ndindex.__eq__
antonwolfy
force-pushed
the
impl-ndindex
branch
from
a22274b to
b19e705
Compare
vtavana
reviewed
Nov 19, 2024
The issue will be resolved by separate PR: #2187 |
vtavana
approved these changes
Nov 20, 2024
github-actions bot
added a commit
that referenced
this pull request
Nov 20, 2024
* Leverage dpnp.ndindex on numpy class * Remove TODO in the code with dpnp.ndindex * Add tests to dpnp.ndindex * Inherit ndindex from numpy class * Instantiate instance of numpy class * Remove TODO in dpnp/dpnp_iface_functional.py * Add tests for __next__() method ffd3829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to add
dpnp.ndindexclass. The implementation is fully leveraged on appropriate class in NumPy.The tests are added to cover the new functionality.