Skip to content

Update dpnp.extract to avoid violation of compute-follows-data #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Nov 14, 2024

In this PR, dpnp.extract implementation is updated to avoid violation of compute-follows-data when both input are dpnp_array.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review November 14, 2024 01:39
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you @vtavana for resolving that.

@antonwolfy antonwolfy merged commit afa6980 into master Nov 14, 2024
45 of 46 checks passed
@antonwolfy antonwolfy deleted the fix-CFD-for-extract branch November 14, 2024 14:16
github-actions bot added a commit that referenced this pull request Nov 14, 2024
antonwolfy added a commit that referenced this pull request Dec 5, 2024
@antonwolfy antonwolfy mentioned this pull request Dec 5, 2024
6 tasks
github-actions bot added a commit that referenced this pull request Dec 5, 2024
antonwolfy added a commit that referenced this pull request Dec 5, 2024
This PR backports of #2172 from development branch to
`maintenance/0.16.x`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants