Remove legacy correlate, dot, and multiply from backend #2183

AlexanderKalistratov · 2024-11-19T04:58:09Z

Removing dot and multiply implementations from backend as no longer needed.

Depends on PR #2183

github-actions · 2024-11-19T05:17:01Z

View rendered docs @ https://intelpython.github.io/dpnp/pull/2183/index.html

dpnp/backend/include/dpnp_iface_fptr.hpp

dpnp/dpnp_algo/dpnp_algo.pyx

dpnp/dpnp_algo/dpnp_algo.pxd

Recent changes in DPC++ 2025.1 compiler broke DPNP compilation. It seems the legacy DPC++ compiler behavior was affected by introducing SYCL experimental extension for reduction properties. Since the compilation issue occurred for a backend function which will be removed once #2183 is merged, that PR proposes to temporary w/a the issue and to reuse the extension for reduction properties, which seems working.

Recent changes in DPC++ 2025.1 compiler broke DPNP compilation. It seems the legacy DPC++ compiler behavior was affected by introducing SYCL experimental extension for reduction properties. Since the compilation issue occurred for a backend function which will be removed once #2183 is merged, that PR proposes to temporary w/a the issue and to reuse the extension for reduction properties, which seems working. ed39ea7

Recent changes in DPC++ 2025.1 compiler broke DPNP compilation. It seems the legacy DPC++ compiler behavior was affected by introducing SYCL experimental extension for reduction properties. Since the compilation issue occurred for a backend function which will be removed once #2183 is merged, that PR proposes to temporary w/a the issue and to reuse the extension for reduction properties, which seems working.

vtavana

Thank you, @AlexanderKalistratov!

dpnp/backend/include/dpnp_gen_2arg_3type_tbl.hpp

dpnp/backend/kernels/dpnp_krnl_common.cpp

dpnp/dpnp_algo/dpnp_algo.pyx

coveralls · 2025-01-07T16:03:32Z

coverage: 70.895% (+5.8%) from 65.08%
when pulling 525b633 on remove_dot_and_multiply_from_backend
into 659629d on master.

AlexanderKalistratov

@antonwolfy Please re-review

dpnp/backend/include/dpnp_gen_2arg_3type_tbl.hpp

dpnp/backend/kernels/dpnp_krnl_common.cpp

dpnp/dpnp_algo/dpnp_algo.pyx

dpnp/dpnp_algo/dpnp_algo.pxd

antonwolfy

Thank you @AlexanderKalistratov LGTM!

Removing `dot` and `multiply` legacy implementations and related legacy utilities from backend as no longer needed. 44bb068

AlexanderKalistratov requested review from antonwolfy, npolina4, vlad-perevezentsev and vtavana as code owners November 19, 2024 04:58

AlexanderKalistratov mentioned this pull request Nov 19, 2024

Implementation of correlate #2180

Merged

AlexanderKalistratov force-pushed the correlate branch from 0d6a4e0 to 9083eeb Compare November 19, 2024 05:20

AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch from c0f0457 to 46762fa Compare November 19, 2024 16:04

AlexanderKalistratov force-pushed the correlate branch from 9083eeb to 8256472 Compare November 20, 2024 02:20

AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch from 46762fa to 2f51c9e Compare November 20, 2024 02:20

AlexanderKalistratov force-pushed the correlate branch from 8256472 to 5f793ab Compare November 20, 2024 03:09

AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch 2 times, most recently from d64c029 to fd2a20d Compare November 20, 2024 03:30

AlexanderKalistratov changed the title ~~Remove dot and multiply from backend~~ Remove legacy correlate, dot, and multiply from backend Nov 20, 2024

AlexanderKalistratov force-pushed the correlate branch from 5f793ab to 2514037 Compare November 20, 2024 04:53

AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch 2 times, most recently from e3feeef to ca1b3ef Compare November 20, 2024 04:56

vtavana reviewed Nov 20, 2024

View reviewed changes

dpnp/backend/include/dpnp_iface_fptr.hpp Show resolved Hide resolved

dpnp/dpnp_algo/dpnp_algo.pyx Outdated Show resolved Hide resolved

dpnp/dpnp_algo/dpnp_algo.pxd Show resolved Hide resolved

AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch from ca1b3ef to 7206e28 Compare November 27, 2024 22:23

AlexanderKalistratov force-pushed the correlate branch 2 times, most recently from fbc94d0 to fa3af10 Compare November 28, 2024 23:09

antonwolfy mentioned this pull request Dec 4, 2024

Use SYCL experimental extension for reduction properties #2211

Merged

6 tasks

AlexanderKalistratov force-pushed the correlate branch from fa3af10 to 70a7d8d Compare December 7, 2024 16:12

AlexanderKalistratov added 2 commits December 7, 2024 17:24

Implementation of correlate

4e26403

Fix signed/unsigned compare warnings & small fixes

9130a53

AlexanderKalistratov force-pushed the correlate branch 2 times, most recently from 936870b to be09e32 Compare December 7, 2024 16:44

Apply review comments

91fd41f

AlexanderKalistratov force-pushed the correlate branch from be09e32 to 91fd41f Compare December 7, 2024 16:57

AlexanderKalistratov added 2 commits December 7, 2024 18:09

Remove legacy correlate, dot, and multiply from backend

ef3a849

Apply review comments

6d17c49

AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch from 7206e28 to 6d17c49 Compare December 7, 2024 17:20

vtavana approved these changes Dec 8, 2024

View reviewed changes

Apply review comments

943726f

AlexanderKalistratov force-pushed the correlate branch from 91fd41f to 943726f Compare December 8, 2024 17:07

Merge branch 'correlate' into remove_dot_and_multiply_from_backend

30fbf2b

Base automatically changed from correlate to master December 9, 2024 20:56

Merge branch 'master' into remove_dot_and_multiply_from_backend

393f8d5

antonwolfy reviewed Dec 11, 2024

View reviewed changes

dpnp/backend/include/dpnp_gen_2arg_3type_tbl.hpp Show resolved Hide resolved

dpnp/backend/kernels/dpnp_krnl_common.cpp Show resolved Hide resolved

dpnp/backend/kernels/dpnp_krnl_common.cpp Show resolved Hide resolved

dpnp/dpnp_algo/dpnp_algo.pyx Show resolved Hide resolved

AlexanderKalistratov added 2 commits January 2, 2025 22:44

Merge branch 'master' into remove_dot_and_multiply_from_backend

dbfcf47

Remove constant.hpp and other review comments

2953588

AlexanderKalistratov added 2 commits January 7, 2025 17:09

Merge branch 'master' into remove_dot_and_multiply_from_backend

9d2ca6b

Merge branch 'master' into remove_dot_and_multiply_from_backend

515fa4e

AlexanderKalistratov commented Jan 8, 2025

View reviewed changes

dpnp/backend/include/dpnp_gen_2arg_3type_tbl.hpp Show resolved Hide resolved

dpnp/backend/kernels/dpnp_krnl_common.cpp Show resolved Hide resolved

dpnp/backend/kernels/dpnp_krnl_common.cpp Show resolved Hide resolved

dpnp/dpnp_algo/dpnp_algo.pyx Show resolved Hide resolved

AlexanderKalistratov requested a review from antonwolfy January 8, 2025 15:50

antonwolfy reviewed Jan 9, 2025

View reviewed changes

dpnp/dpnp_algo/dpnp_algo.pxd Outdated Show resolved Hide resolved

Remove dpnp_memory_* and dpnp_rng_srand_c from dpnp_algo.pxd

525b633

antonwolfy approved these changes Jan 13, 2025

View reviewed changes

AlexanderKalistratov added 2 commits January 13, 2025 14:49

Merge branch 'master' into remove_dot_and_multiply_from_backend

3db58e8

Merge branch 'master' into remove_dot_and_multiply_from_backend

0ac235c

AlexanderKalistratov merged commit 44bb068 into master Jan 13, 2025
58 of 60 checks passed

AlexanderKalistratov deleted the remove_dot_and_multiply_from_backend branch January 13, 2025 21:15

github-actions bot added a commit that referenced this pull request Jan 13, 2025

Remove legacy correlate, dot, and multiply from backend (#2183)

66c13bc

Removing `dot` and `multiply` legacy implementations and related legacy utilities from backend as no longer needed. 44bb068

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove legacy correlate, dot, and multiply from backend #2183

Remove legacy correlate, dot, and multiply from backend #2183

Uh oh!

AlexanderKalistratov commented Nov 19, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vtavana left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Jan 7, 2025 •

edited

Loading

Uh oh!

AlexanderKalistratov left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antonwolfy left a comment

Uh oh!

Uh oh!

Uh oh!

Remove legacy correlate, dot, and multiply from backend #2183

Remove legacy correlate, dot, and multiply from backend #2183

Uh oh!

Conversation

AlexanderKalistratov commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vtavana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexanderKalistratov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antonwolfy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AlexanderKalistratov commented Nov 19, 2024 •

edited

Loading

coveralls commented Jan 7, 2025 •

edited

Loading