Skip to content

fix test_digitize_error #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix test_digitize_error #2204

merged 1 commit into from
Nov 29, 2024

Conversation

AlexanderKalistratov
Copy link
Collaborator 

with pytest.raises(TypeError):
    dpnp.digitize(x_np, bins_dp)
    dpnp.digitize(x_dp, bins_np)  # <= unreachable line
with pytest.raises(TypeError):
    dpnp.digitize(x_np, bins_dp)
with pytest.raises(TypeError):
    dpnp.digitize(x_dp, bins_np)  # <= reachable line
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AlexanderKalistratov for catching this. The below comment is just FYI about alternative implementation.

@AlexanderKalistratov AlexanderKalistratov merged commit 5c9f855 into master Nov 29, 2024
48 checks passed
@AlexanderKalistratov AlexanderKalistratov deleted the fix_digitize_test branch November 29, 2024 13:22
github-actions bot added a commit that referenced this pull request Nov 29, 2024
@github-actions
fix test_digitize_error (#2204)
63ff816 
```python
with pytest.raises(TypeError):
    dpnp.digitize(x_np, bins_dp)
    dpnp.digitize(x_dp, bins_np)  # <= unreachable line
```

```python
with pytest.raises(TypeError):
    dpnp.digitize(x_np, bins_dp)
with pytest.raises(TypeError):
    dpnp.digitize(x_dp, bins_np)  # <= reachable line
```

- [x] Have you provided a meaningful PR description?
- [x] Have you added a test, reproducer or referred to issue with a
reproducer?
- [x] Have you tested your changes locally for CPU and GPU devices?
- [x] Have you made sure that new changes do not introduce compiler
warnings?
- [x] Have you checked performance impact of proposed changes?
- [x] If this PR is a work in progress, are you filing the PR as a
draft? 5c9f855
vtavana pushed a commit that referenced this pull request Dec 2, 2024
@AlexanderKalistratov @vtavana
fix test_digitize_error (#2204)
acde046 
```python
with pytest.raises(TypeError):
    dpnp.digitize(x_np, bins_dp)
    dpnp.digitize(x_dp, bins_np)  # <= unreachable line
```

```python
with pytest.raises(TypeError):
    dpnp.digitize(x_np, bins_dp)
with pytest.raises(TypeError):
    dpnp.digitize(x_dp, bins_np)  # <= reachable line
```

- [x] Have you provided a meaningful PR description?
- [x] Have you added a test, reproducer or referred to issue with a
reproducer?
- [x] Have you tested your changes locally for CPU and GPU devices?
- [x] Have you made sure that new changes do not introduce compiler
warnings?
- [x] Have you checked performance impact of proposed changes?
- [x] If this PR is a work in progress, are you filing the PR as a
draft?
vtavana pushed a commit that referenced this pull request Dec 2, 2024
@AlexanderKalistratov @vtavana
fix test_digitize_error (#2204)
794906e 
```python
with pytest.raises(TypeError):
    dpnp.digitize(x_np, bins_dp)
    dpnp.digitize(x_dp, bins_np)  # <= unreachable line
```

```python
with pytest.raises(TypeError):
    dpnp.digitize(x_np, bins_dp)
with pytest.raises(TypeError):
    dpnp.digitize(x_dp, bins_np)  # <= reachable line
```

- [x] Have you provided a meaningful PR description?
- [x] Have you added a test, reproducer or referred to issue with a
reproducer?
- [x] Have you tested your changes locally for CPU and GPU devices?
- [x] Have you made sure that new changes do not introduce compiler
warnings?
- [x] Have you checked performance impact of proposed changes?
- [x] If this PR is a work in progress, are you filing the PR as a
draft?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderKalistratov @antonwolfy