-
Notifications
You must be signed in to change notification settings - Fork 22
Align with numpy 2.2 #2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Align with numpy 2.2 #2226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
39c83d7
to
eaa79fa
Compare
4666ab5
to
da44614
Compare
4eb5fd3
to
a10b491
Compare
vtavana
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @antonwolfy!
github-actions bot
added a commit
that referenced
this pull request
Dec 9, 2024
The PR proposes to align with changes implemented in `numpy 2.2`: - Update `dpnp.cov` to properly transpose 2d array with `rowvar=False`. - Handle boolean arrays in `dpnp.insert` as a mask. - Mute or workaround tests with fail due to numpy issues in `numpy.insert` and `numpy.cov`. - Mute tests with are not passing due to new numpy behavior (new `matvec` and `vecmat` ufuncs, support of 2d array in `trim_zeros`). `matvec` and `vecmat` ufuncs and `trim_zeros` functions will be separately. 11487c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to align with changes implemented in
numpy 2.2
:dpnp.cov
to properly transpose 2d array withrowvar=False
.dpnp.insert
as a mask.numpy.insert
andnumpy.cov
.matvec
andvecmat
ufuncs, support of 2d array intrim_zeros
).matvec
andvecmat
ufuncs andtrim_zeros
functions will be separately.