Skip to content

Align with numpy 2.2 #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 9, 2024
Merged

Align with numpy 2.2 #2226

merged 11 commits into from
Dec 9, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 9, 2024

The PR proposes to align with changes implemented in numpy 2.2:

  • Update dpnp.cov to properly transpose 2d array with rowvar=False.
  • Handle boolean arrays in dpnp.insert as a mask.
  • Mute or workaround tests with fail due to numpy issues in numpy.insert and numpy.cov.
  • Mute tests with are not passing due to new numpy behavior (new matvec and vecmat ufuncs, support of 2d array in trim_zeros).

matvec and vecmat ufuncs and trim_zeros functions will be separately.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy force-pushed the align-with-numpy-2.2 branch from 39c83d7 to eaa79fa Compare December 9, 2024 15:45
@antonwolfy antonwolfy force-pushed the align-with-numpy-2.2 branch from 4666ab5 to da44614 Compare December 9, 2024 17:04
@antonwolfy antonwolfy force-pushed the align-with-numpy-2.2 branch from 4eb5fd3 to a10b491 Compare December 9, 2024 18:53
@antonwolfy antonwolfy marked this pull request as ready for review December 9, 2024 19:47
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 11487c5 into master Dec 9, 2024
47 of 48 checks passed
@antonwolfy antonwolfy deleted the align-with-numpy-2.2 branch December 9, 2024 23:30
github-actions bot added a commit that referenced this pull request Dec 9, 2024
The PR proposes to align with changes implemented in `numpy 2.2`:
- Update `dpnp.cov` to properly transpose 2d array with `rowvar=False`.
- Handle boolean arrays in `dpnp.insert` as a mask.
- Mute or workaround tests with fail due to numpy issues in
`numpy.insert` and `numpy.cov`.
- Mute tests with are not passing due to new numpy behavior (new
`matvec` and `vecmat` ufuncs, support of 2d array in `trim_zeros`).

`matvec` and `vecmat` ufuncs and `trim_zeros` functions will be
separately. 11487c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants