Skip to content

Improve performance of dnp.nan_to_num #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Feb 5, 2025
Merged

Improve performance of dnp.nan_to_num #2228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
31d9c82
Add kernel for nan_to_num to ufunc extension
ndgrigorian Dec 10, 2024
5ad83b0
Add missing headers in nan_to_num.cpp
ndgrigorian Dec 10, 2024
d99c0d5
Add contiguous kernel for nan_to_num
ndgrigorian Dec 10, 2024
13cd3b5
Fix missed ssize_t to dpctl::tensor::ssize_t
ndgrigorian Dec 10, 2024
f4c6782
Clean-up nan_to_num.cpp dead code
ndgrigorian Dec 10, 2024
3772815
Use dpnp.copy instead of copy method in nan_to_num
ndgrigorian Dec 10, 2024
ffb1379
Fix typo in nan_to_num
ndgrigorian Dec 10, 2024
16d4ea2
inline to_num in nan_to_num kernel
ndgrigorian Dec 10, 2024
cd13f40
Add additional const qualifiers in nan_to_num impl functions
ndgrigorian Dec 10, 2024
533963c
Use is_complex_v in nan_to_num kernel
ndgrigorian Dec 10, 2024
99cc211
Simplify nan_to_num call logic
ndgrigorian Dec 10, 2024
dc6e7f9
Improve test coverage for nan_to_num
ndgrigorian Jan 12, 2025
cc45176
Align with changes to device_allocate_and_pack in dpctl
ndgrigorian Jan 12, 2025
00e51ad
Add subgroup load and store based implementation for nan_to_num kernel
ndgrigorian Jan 28, 2025
9dd3e60
size_t -> std::size_t in nan_to_num Python binding
ndgrigorian Jan 29, 2025
e9953f5
nan_to_num always returns dpnp_array
ndgrigorian Feb 5, 2025
99fd28b
Apply review comments
ndgrigorian Feb 5, 2025
3acc9c4
nan_to_num_impl -> nan_to_num_strided_impl
ndgrigorian Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dpnp/backend/extensions/ufunc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ set(_elementwise_sources
${CMAKE_CURRENT_SOURCE_DIR}/elementwise_functions/lcm.cpp
${CMAKE_CURRENT_SOURCE_DIR}/elementwise_functions/ldexp.cpp
${CMAKE_CURRENT_SOURCE_DIR}/elementwise_functions/logaddexp2.cpp
${CMAKE_CURRENT_SOURCE_DIR}/elementwise_functions/nan_to_num.cpp
${CMAKE_CURRENT_SOURCE_DIR}/elementwise_functions/radians.cpp
${CMAKE_CURRENT_SOURCE_DIR}/elementwise_functions/sinc.cpp
${CMAKE_CURRENT_SOURCE_DIR}/elementwise_functions/spacing.cpp
Expand Down
2 changes: 2 additions & 0 deletions dpnp/backend/extensions/ufunc/elementwise_functions/common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
#include "lcm.hpp"
#include "ldexp.hpp"
#include "logaddexp2.hpp"
#include "nan_to_num.hpp"
#include "radians.hpp"
#include "sinc.hpp"
#include "spacing.hpp"
Expand All @@ -64,6 +65,7 @@ void init_elementwise_functions(py::module_ m)
init_lcm(m);
init_ldexp(m);
init_logaddexp2(m);
init_nan_to_num(m);
init_radians(m);
init_sinc(m);
init_spacing(m);
Expand Down
Loading
Loading