Add integer dtypes (int8, int16, uint8-uint64) to dpnp interface #2230

AlexanderKalistratov · 2024-12-11T19:05:04Z

Add missing aliases to integer types: [u]byte, ushort, [u]longlong Not adding [u]long aliases as it is removed from NumPy (https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations) Removed int alias as it is depricate in NumPy
Extend tests types matrix by these types
Add environment variable DPNP_TEST_ALL_INT_TYPES to enable/disable these types in tests.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you filing the PR as a draft?

Add missing aliases to integer types: [u]byte, ushort, [u]longlong Not adding [u]long aliases as it is removed from NumPy (https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations) Removed int alias as it is depricate in NumPy Extend tests types matrix by these types Add environment variable DPNP_TEST_ALL_TYPES to enable/disable these types in tests Failing dpnp tests: test_arraycreation.py::test_geomspace test_arraycreation.py::test_linspace test_arraycreation.py::test_logspace test_fft.py::TestFft2::test_fft2 test_fft.py::TestRfft2::test_rfft2 test_histogram.py::TestDigitize::test_digitize test_indexing.py::TestPut::test_input_1d test_indexing.py::TestPut::test_input_2d test_indexing.py::TestPutAlongAxis::test_replace_max test_indexing.py::TestTake::test_1d test_indexing.py::TestTake::test_2d test_indexing.py::TestTakeAlongAxis::test_broadcast test_indexing.py::TestTakeAlongAxis::test_empty test_indexing.py::TestTakeAlongAxis::test_empty test_indexing.py::TestTakeAlongAxis::test_multi_dimensions test_linalg.py::TestCond::test_cond test_linalg.py::TestEigenvalue::test_eigenvalues test_linalg.py::TestLstsq::test_lstsq_diff_type test_linalg.py::TestNorm::test_norm_1D test_linalg.py::TestNorm::test_norm_2D test_linalg.py::TestNorm::test_norm_ND test_linalg.py::TestNorm::test_norm_usm_ndarray test_linalg.py::TestPinv::test_pinv test_linalg.py::TestQr::test_qr test_linalg.py::TestSvd::test_svd test_manipulation.py::TestUnique::test_2d_axis_signed_inetger test_manipulation.py::test_copyto_dtype test_mathematical.py::TestAngle::test_angle test_mathematical.py::TestCumLogSumExp::test_basic test_mathematical.py::TestCumProd::test_out_dtype test_mathematical.py::TestCumSum::test_out_dtype test_mathematical.py::TestFix::test_basic test_mathematical.py::TestFix::test_out test_mathematical.py::TestHypot::test_hypot test_mathematical.py::TestLogSumExp::test_logsumexp test_mathematical.py::TestLogSumExp::test_logsumexp_dtype test_mathematical.py::TestLogSumExp::test_logsumexp_out test_mathematical.py::TestLogSumExp::test_logsumexp_out_dtype test_mathematical.py::TestMathematical::test_remainder test_mathematical.py::TestMatmul::test_matmul_axes_ND_ND test_mathematical.py::TestMatmul::test_matmul_axes_out test_mathematical.py::TestMatmul::test_matmul_dtype test_mathematical.py::TestMatmul::test_matmul_dtype_matrix_inout test_mathematical.py::TestMatmul::test_matmul_dtype_matrix_inputs test_mathematical.py::TestMatmul::test_matmul_out1 test_mathematical.py::TestMatmul::test_matmul_out2 test_mathematical.py::TestPower::test_basic test_mathematical.py::TestProd::test_prod_out_dtype test_mathematical.py::TestReduceHypot::test_reduce_hypot test_mathematical.py::TestReduceHypot::test_reduce_hypot_dtype test_mathematical.py::TestReduceHypot::test_reduce_hypot_out test_mathematical.py::TestUnwrap::test_discont test_mathematical.py::TestUnwrap::test_rand_period test_nanfunctions.py::TestNanProd::test_nanprod_out_dtype test_product.py::TestDot::test_dot test_product.py::TestDot::test_dot_ndarray test_product.py::TestDot::test_dot_out test_product.py::TestDot::test_dot_out_scalar test_product.py::TestDot::test_dot_scalar test_product.py::TestInner::test_inner test_product.py::TestInner::test_inner_scalar test_product.py::TestKron::test_kron_scalar test_product.py::TestMultiDot::test_multi_dot test_product.py::TestMultiDot::test_multi_dot_all_2d test_product.py::TestMultiDot::test_multi_dot_out test_product.py::TestTensordot::test_tensordot test_product.py::TestTensordot::test_tensordot_axes test_product.py::TestTensordot::test_tensordot_input_dtype_matrix test_product.py::TestTensordot::test_tensordot_scalar test_sort.py::test_partition test_statistics.py::TestAverage::test_avg test_statistics.py::TestAverage::test_avg_strided test_statistics.py::TestStd::test_std_strided test_statistics.py::TestVar::test_var_strided test_statistics.py::test_median test_strides.py::test_cumlogsumexp test_strides.py::test_logsumexp test_strides.py::test_reduce_hypot test_strides.py::test_strides_erf test_sum.py::test_sum test_umath.py::TestArctan2::test_arctan2 test_umath.py::TestCbrt::test_cbrt test_umath.py::TestCopySign::test_copysign test_umath.py::TestFloatPower::test_negative_base_value_complex_dtype test_umath.py::TestLogAddExp::test_logaddexp test_umath.py::TestRsqrt::test_rsqrt test_umath.py::TestUmath::test_out

#2233) In this PR, tests are update to pass with newly added integer dtypes (int8, int16, uint8, uint16, uint32, uint64). This PR is in continuation of #2230.

coveralls · 2025-01-23T22:34:28Z

coverage: 71.63% (+0.001%) from 71.629%
when pulling 6592abc on extended_types_support
into db97d59 on master.

github-actions · 2025-01-24T16:02:51Z

Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_7 ran successfully.
Passed: 971
Failed: 0
Skipped: 43

github-actions · 2025-01-28T15:39:49Z

View rendered docs @ https://intelpython.github.io/dpnp/index.html

github-actions · 2025-01-28T16:08:12Z

Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_30 ran successfully.
Passed: 992
Failed: 0
Skipped: 22

In this PR, the GitHub workflow is update to run the test suit with all integer dtypes when the lates python is used. In addition, newly added tests are updated to pass with all integer dtypes.

antonwolfy

Thank you @vtavana for that great effort in implementing that. I believe we are ready to merge that now. No more comments from me.

Add missing aliases to integer types: [u]byte, ushort, [u]longlong Not adding [u]long aliases as it is removed from NumPy (https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations) Removed int alias as it is depricate in NumPy Extend tests types matrix by these types Add environment variable DPNP_TEST_ALL_INT_TYPES to enable/disable these types in tests. 426da51

After merging #2230, coverage for `dpnp.iface_manipulation.py` was decreased related to `dpnp.copyto` function. This PR adds new tests to improve the coverage and updates the logic used in `dpnp.copyto` to pass the new tests.

After merging #2230, coverage for `dpnp.iface_manipulation.py` was decreased related to `dpnp.copyto` function. This PR adds new tests to improve the coverage and updates the logic used in `dpnp.copyto` to pass the new tests. e24fa99

antonwolfy changed the title ~~Add integer dtypes (int8,int16, uint8-uint64) to dpnp interface~~ Add integer dtypes (int8, int16, uint8-uint64) to dpnp interface Dec 11, 2024

vtavana mentioned this pull request Dec 17, 2024

update tests for newly added integr dtypes (int8, int16, uint8-uint64) #2233

Merged

6 tasks

vtavana and others added 2 commits January 23, 2025 14:00

update tests for newly added integr dtypes (int8, int16, uint8-uint64) (

9c28750

#2233) In this PR, tests are update to pass with newly added integer dtypes (int8, int16, uint8, uint16, uint32, uint64). This PR is in continuation of #2230.

merge with master branch and resolve conflicts

eb68f63

vtavana and others added 3 commits January 24, 2025 07:15

update newly added tests for elemnt-wise in-place operators

d0870b1

remove debugging leftover

56db205

Merge branch 'master' into extended_types_support

a9af727

vtavana self-assigned this Jan 24, 2025

vtavana marked this pull request as ready for review January 24, 2025 16:32

vtavana requested review from antonwolfy, vlad-perevezentsev and vtavana as code owners January 24, 2025 16:32

vtavana and others added 2 commits January 28, 2025 09:17

Merge branch 'master' into extended_types_support

33a6608

update TODOs in test_array_api_info.py

191688b

vtavana and others added 11 commits January 28, 2025 09:33

update yaml file

43fb4cd

update yaml file

1c50270

Merge branch 'master' into extended_types_support

bd98e7a

Merge branch 'master' into extended_types_support

7c59295

unmute array-api-test

e90eba9

Merge branch 'master' into extended_types_support

66ef596

Merge branch 'master' into extended_types_support

98983bd

Merge branch 'master' into extended_types_support

6592abc

update puclic CI workflow for all integer dtypes (#2298)

e01c969

In this PR, the GitHub workflow is update to run the test suit with all integer dtypes when the lates python is used. In addition, newly added tests are updated to pass with all integer dtypes.

Merge branch 'master' into extended_types_support

6549d2b

Merge branch 'master' into extended_types_support

995c385

antonwolfy approved these changes Feb 13, 2025

View reviewed changes

Merge branch 'master' into extended_types_support

14ece2e

vtavana merged commit 426da51 into master Feb 14, 2025
66 of 69 checks passed

vtavana deleted the extended_types_support branch February 14, 2025 00:58

vtavana mentioned this pull request Feb 18, 2025

improve covergae dpnp_iface_manipulation.py #2326

Merged

6 tasks

antonwolfy mentioned this pull request Mar 31, 2025

Fragmented support of numpy type aliases #1376

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add integer dtypes (int8, int16, uint8-uint64) to dpnp interface #2230

Add integer dtypes (int8, int16, uint8-uint64) to dpnp interface #2230

Uh oh!

AlexanderKalistratov commented Dec 11, 2024 •

edited by vtavana

Loading

Uh oh!

coveralls commented Jan 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 24, 2025

Uh oh!

github-actions bot commented Jan 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 28, 2025 •

edited

Loading

Uh oh!

antonwolfy left a comment

Uh oh!

Uh oh!

Uh oh!

Add integer dtypes (int8, int16, uint8-uint64) to dpnp interface #2230

Add integer dtypes (int8, int16, uint8-uint64) to dpnp interface #2230

Uh oh!

Conversation

AlexanderKalistratov commented Dec 11, 2024 • edited by vtavana Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 24, 2025

Uh oh!

github-actions bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonwolfy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AlexanderKalistratov commented Dec 11, 2024 •

edited by vtavana

Loading

coveralls commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading