Skip to content

simplifying a utility function for reduction operation #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 16, 2024
Merged

simplifying a utility function for reduction operation #2234

merged 6 commits into from
Dec 16, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Dec 13, 2024 •
edited
Loading

In this PR, a utility function (dpnp_wrap_reduction_call) for reduction operation is simplified.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Dec 13, 2024 •
edited
Loading

Coverage Status

coverage: 65.086% (-0.004%) from 65.09%
when pulling b3a0232 on update-dpnp_wrap_reduction_call
into 584f0cb on master.

@vtavana vtavana marked this pull request as ready for review December 13, 2024 17:48
antonwolfy
antonwolfy approved these changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for the improvement implemented

@vtavana vtavana merged commit 904227e into master Dec 16, 2024
42 of 48 checks passed
@vtavana vtavana deleted the update-dpnp_wrap_reduction_call branch December 16, 2024 17:02
github-actions bot added a commit that referenced this pull request Dec 16, 2024
@github-actions
simplifying a utility function for reduction operation (#2234)
9850ace 
In this PR, a utility function (`dpnp_wrap_reduction_call`) for
reduction operation is simplified. 904227e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy