Skip to content

Add environment file to GitHub workflows #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 21, 2025
Merged

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 13, 2025

The PR proposes to update GitHub workflows which used miniconda and to install all required conda packages through passing an environment file by single step. It will make the jibs more robust against connectivity issues which occur often during downloading conda packages.

There are dedicated yaml files with min set of required packages introduced to reuse them in different jobs/workflows with common requirements. In case when few yaml files needs to be merged into one environment.yml there is conda-merge tool used.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 13, 2025
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2258/index.html

@antonwolfy antonwolfy force-pushed the stabilize-public-ci-part-3 branch 6 times, most recently from a2500eb to 7c1869c Compare January 13, 2025 21:07
@antonwolfy antonwolfy force-pushed the stabilize-public-ci-part-3 branch 2 times, most recently from f6baa58 to 475291b Compare January 14, 2025 12:57
@coveralls
Copy link
Collaborator

coveralls commented Jan 14, 2025

Coverage Status

coverage: 71.781%. remained the same
when pulling 3f15020 on stabilize-public-ci-part-3
into e24fa99 on master.

@antonwolfy antonwolfy force-pushed the stabilize-public-ci-part-3 branch from 475291b to 469f633 Compare January 20, 2025 16:29
Copy link
Contributor

github-actions bot commented Jan 20, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Array API standard conformance tests for dpnp=0.17.0dev7=py312he4f9c94_14 ran successfully.
Passed: 1004
Failed: 0
Skipped: 10

@antonwolfy antonwolfy force-pushed the stabilize-public-ci-part-3 branch 15 times, most recently from ad0ab0d to c293927 Compare February 15, 2025 11:10
@antonwolfy antonwolfy marked this pull request as ready for review February 15, 2025 12:04
@antonwolfy antonwolfy force-pushed the stabilize-public-ci-part-3 branch 3 times, most recently from e71ad51 to 91c0f8b Compare February 20, 2025 09:53
@antonwolfy antonwolfy force-pushed the stabilize-public-ci-part-3 branch from dcaaef1 to d8629c8 Compare February 20, 2025 11:08
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!
Thank you @antonwolfy for optimizing dependency management for jobs

@antonwolfy antonwolfy merged commit 0490fcc into master Feb 21, 2025
66 of 67 checks passed
@antonwolfy antonwolfy deleted the stabilize-public-ci-part-3 branch February 21, 2025 11:52
github-actions bot added a commit that referenced this pull request Feb 21, 2025
The PR proposes to update GitHub workflows which used miniconda and to
install all required conda packages through passing an environment file
by single step. It will make the jibs more robust against connectivity
issues which occur often during downloading conda packages.

There are dedicated yaml files with min set of required packages
introduced to reuse them in different jobs/workflows with common
requirements. In case when few yaml files needs to be merged into one
`environment.yml` there is `conda-merge` tool used. 0490fcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants