Skip to content

Align timeouts on running tests in public CI on Linux #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 20, 2025

The timeout was set up to 12 minutes in Conda package workflow.
That PR proposes to align it across all GitHub workflows where tests are running on Linux.

Sometimes the current timeout of 10 minutes might not be enough (like here in Test oneMKL interfaces workflow) which caused unexpected failure or extra rerunning attempt.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 70.844%. remained the same
when pulling 5b5a6ca on align-tests-timeout
into 807179a on master.

@antonwolfy antonwolfy changed the title Align timeouts to run tests in public CI on Linux Align timeouts on running tests in public CI on Linux Jan 20, 2025
Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_9 ran successfully.
Passed: 950
Failed: 0
Skipped: 50

@vlad-perevezentsev vlad-perevezentsev self-requested a review January 20, 2025 16:46
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 7ce5219 into master Jan 20, 2025
46 of 53 checks passed
@antonwolfy antonwolfy deleted the align-tests-timeout branch January 20, 2025 16:56
github-actions bot added a commit that referenced this pull request Jan 20, 2025
The timeout was set up to 12 minutes in `Conda package` workflow.
That PR proposes to align it across all GitHub workflows where tests are
running on Linux.

Sometimes the current timeout of 10 minutes might not be enough (like
[here](https://github.com/IntelPython/dpnp/actions/runs/12870503193/job/35883466675?pr=2266)
in `Test oneMKL interfaces` workflow) which caused unexpected failure or
extra rerunning attempt. 7ce5219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants