Skip to content

Remove mentioning of tostring method #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

Remove mentioning of tostring method #2309

merged 1 commit into from
Feb 12, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 12, 2025 •
edited
Loading

numpy.ndarray.tostring method was deprecated since 1.19 and is going to be removed in 2.3.0 release.

This PR proposes to remove mentioning of tostring method in a list of rendered documentation and as TODO method for implementation in dpnp.ndarray.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Feb 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_9 ran successfully.
Passed: 977
Failed: 0
Skipped: 23

vlad-perevezentsev
vlad-perevezentsev approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 0bda96a into master Feb 12, 2025
69 of 70 checks passed
@antonwolfy antonwolfy deleted the remove-todo-with-tostring-method branch February 12, 2025 13:48
github-actions bot added a commit that referenced this pull request Feb 12, 2025
@github-actions
Remove mentioning of tostring method (#2309)
a56a6ee 
`numpy.ndarray.tostring` method was deprecated since `1.19` and is going
to be removed in `2.3.0` release.

This PR proposes to remove mentioning of `tostring` method in a list of
rendered documentation and as TODO method for implementation in
`dpnp.ndarray`. 0bda96a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev