Skip to content

Resolve typos in the job for Clean up anaconda packages #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

Resolve typos in the job for Clean up anaconda packages #2331

merged 1 commit into from
Feb 21, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 21, 2025 •
edited
Loading

The PR update GitHub workflow with Conda package to resolve typos in Clean up anaconda packages job there.
There was empty string passed as a name of env file for miniconda resulting to incomplete environment created.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Feb 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.781%. remained the same
when pulling 8ee5809 on update-cleanup-packages-job
into 0490fcc on master.

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev7=py312he4f9c94_7 ran successfully.
Passed: 1004
Failed: 0
Skipped: 10

vlad-perevezentsev
vlad-perevezentsev approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @antonwolfy

@antonwolfy antonwolfy merged commit fbb56be into master Feb 21, 2025
63 of 66 checks passed
@antonwolfy antonwolfy deleted the update-cleanup-packages-job branch February 21, 2025 14:54
github-actions bot added a commit that referenced this pull request Feb 21, 2025
@github-actions
Resolve typos in the job for Clean up anaconda packages (#2331)
3150bba 
The PR update GitHub workflow with `Conda package` to resolve typos in
`Clean up anaconda packages` job there.
There was empty string passed as a name of env file for miniconda
resulting to incomplete environment created. fbb56be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antonwolfy @coveralls @vlad-perevezentsev @vtavana