Fixing memory corruption #2333
Merged
Fixing memory corruption #2333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.17.0rc1=py312he4f9c94_6 ran successfully. |
antonwolfy
reviewed
Feb 21, 2025
AlexanderKalistratov
requested review from
vlad-perevezentsev,
vtavana and
ndgrigorian
as code owners
antonwolfy
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Thank you @AlexanderKalistratov for the workaround implemented. LGTM!
github-actions bot
added a commit
that referenced
this pull request
Feb 25, 2025
- [x] Have you provided a meaningful PR description? - [x] Have you added a test, reproducer or referred to issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [x] If this PR is a work in progress, are you filing the PR as a draft? Temporary workaround for memory corruption inside correlate kernel. The root cause is still unknown, but the workaround seems to solve crashes 355e959
antonwolfy
pushed a commit
that referenced
this pull request
Feb 25, 2025
- [x] Have you provided a meaningful PR description? - [x] Have you added a test, reproducer or referred to issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [x] If this PR is a work in progress, are you filing the PR as a draft? Temporary workaround for memory corruption inside correlate kernel. The root cause is still unknown, but the workaround seems to solve crashes
antonwolfy
added a commit
that referenced
this pull request
Feb 25, 2025
antonwolfy
added a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary workaround for memory corruption inside correlate kernel.
The root cause is still unknown, but the workaround seems to solve crashes