Add support of uint64 dtype in dpnp.bincount
#2361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_39 ran successfully. |
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev,
vtavana and
ndgrigorian
as code owners
github-actions bot
added a commit
that referenced
this pull request
Mar 7, 2025
Previously NumPy prohibits `uint64` dtype of input array in `numpy.bincount`. But that is going to be changed since `2.2.4` release (fixed in numpy#28355 and backported to 2.2.x branch in numpy#28420). This PR proposes to align with upcoming changes and to allow `uint64` dtype of input array in `dpnp.bincount`. Additionally, it extends the docstring of histogram-like functions to clearly notify with a warning about possible synchronization impact. acd33e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously NumPy prohibits
uint64dtype of input array innumpy.bincount. But that is going to be changed since2.2.4release (fixed in numpy#28355 and backported to 2.2.x branch in numpy#28420).This PR proposes to align with upcoming changes and to allow
uint64dtype of input array indpnp.bincount.Additionally, it extends the docstring of histogram-like functions to clearly notify with a warning about possible synchronization impact.