Skip to content

Fix an issue in conda-package.yml #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2025
Merged

Fix an issue in conda-package.yml #2364

merged 2 commits into from
Mar 6, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Mar 5, 2025 •
edited
Loading

In this PR, an issue in conda-package.yml file is fixed to properly run tests with all integer dtypes on windows when DPNP_TEST_ALL_INT_TYPES=1.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Mar 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Mar 5, 2025 •
edited
Loading

Coverage Status

coverage: 71.961%. remained the same
when pulling a981ac6 on fix-all-int-windows
into 70dea63 on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_27 ran successfully.
Passed: 1006
Failed: 0
Skipped: 17

@vtavana vtavana changed the title update yaml file for test_windows Fix an issue in conda-package.yml Mar 5, 2025
@vtavana vtavana force-pushed the fix-all-int-windows branch from f8878d0 to efeb836 Compare March 6, 2025 00:15
@vtavana vtavana marked this pull request as ready for review March 6, 2025 00:15
antonwolfy
antonwolfy approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for noticing that and implementing the fix.

@vtavana vtavana merged commit 25fb39b into master Mar 6, 2025
66 of 67 checks passed
@vtavana vtavana deleted the fix-all-int-windows branch March 6, 2025 21:18
github-actions bot added a commit that referenced this pull request Mar 6, 2025
@github-actions
Fix an issue in conda-package.yml (#2364)
7ce732b 
In this PR, an issue in `conda-package.yml` file is fixed to properly
run tests with all integer dtypes on windows when
`DPNP_TEST_ALL_INT_TYPES=1`. 25fb39b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy