Install dpctl via pip manager in coverage and docs workflows #2383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev,
vtavana and
ndgrigorian
as code owners
antonwolfy
added
the
github_actions
7 tasks
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_44 ran successfully. |
vtavana
approved these changes
Mar 24, 2025
github-actions bot
added a commit
that referenced
this pull request
Mar 25, 2025
This PR resolves issue with `coverage` and `docs` GitHub workflows observing since 2025.1 release is published. The reason of the proposed changes is that it isn't possible to install dpctl there as a conda package when the environment is created through installing of Intel OneAPI packages because the dpctl conda package has a runtime dependency on DPC++ RT one. Whereas the DPC++ RT package has been already installed by the apt command above and its version has been matched with the DPC++ compiler. In case where we install the DPC++ compiler with the apt (including DPC++ RT) and install the DPC++ RT conda package while resolving dependencies, this can lead to a versioning error, i.e. compatibility issue as the DPC++ compiler only guarantees backwards compatibility, not forward compatibility (DPC++ RT may not run a binary built with a newer version of the DPC++ compiler). Installing dpctl via the pip manager has no such limitation, as the package has no run dependency on the DPC++ RT pip package, so this is why the new step is proposed to be added to the workflows. 395c896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue with
coverageanddocsGitHub workflows observing since 2025.1 release is published.The reason of the proposed changes is that it isn't possible to install dpctl there as a conda package when the environment is created through installing of Intel OneAPI packages because the dpctl conda package has a runtime dependency on DPC++ RT one. Whereas the DPC++ RT package has been already installed by the apt command above and its version has been matched with the DPC++ compiler.
In case where we install the DPC++ compiler with the apt (including DPC++ RT) and install the DPC++ RT conda package while resolving dependencies, this can lead to a versioning error, i.e. compatibility issue as the DPC++ compiler only guarantees backwards compatibility, not forward compatibility (DPC++ RT may not run a binary built with a newer version of the DPC++ compiler).
Installing dpctl via the pip manager has no such limitation, as the package has no run dependency on the DPC++ RT pip package, so this is why the new step is proposed to be added to the workflows.