Skip to content

define a new helper function for tests called get_integer_float_dtypes #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2025
Merged

define a new helper function for tests called get_integer_float_dtypes #2402

merged 4 commits into from
Apr 1, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Mar 31, 2025

A new helper function is defined for tests, to get integer and float dtypes.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Mar 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 72.236%. remained the same
when pulling 5893524 on new-helper-func
into f74b5a8 on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_67 ran successfully.
Passed: 1197
Failed: 0
Skipped: 14

@vtavana vtavana marked this pull request as ready for review March 31, 2025 22:26
antonwolfy
antonwolfy reviewed Apr 1, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana, LGTM

@vtavana vtavana merged commit d2da986 into master Apr 1, 2025
64 of 66 checks passed
@vtavana vtavana deleted the new-helper-func branch April 1, 2025 18:26
github-actions bot added a commit that referenced this pull request Apr 1, 2025
@github-actions
define a new helper function for tests called `get_integer_float_dtyp…
6f15b95 
…es` (#2402)

A new helper function is defined for tests, to get integer and float
dtypes. d2da986
antonwolfy pushed a commit that referenced this pull request Apr 2, 2025
@vtavana @antonwolfy
define a new helper function for tests called `get_integer_float_dtyp…
4d04886 
…es` (#2402)

A new helper function is defined for tests, to get integer and float
dtypes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy