Skip to content

Cast test env variables with dtype scope to boolean value #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 13, 2025
Merged

Cast test env variables with dtype scope to boolean value #2415

merged 3 commits into from
Apr 13, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 10, 2025 •
edited
Loading

The PR closes #2324. It is proposes to cast test env variables with dtype scope to boolean value which can handle empty string as a False value.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Apr 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Apr 10, 2025 •
edited
Loading

Coverage Status

coverage: 72.271%. remained the same
when pulling 71f8fa4 on fix-gh-2324
into bbe197a on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_81 ran successfully.
Passed: 1219
Failed: 0
Skipped: 10

ndgrigorian
ndgrigorian approved these changes Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, can now run tests with DPNP_TEST_ALL_INT_TYPES=

LGTM

@antonwolfy antonwolfy merged commit 130a24a into master Apr 13, 2025
68 checks passed
@antonwolfy antonwolfy deleted the fix-gh-2324 branch April 13, 2025 06:32
github-actions bot added a commit that referenced this pull request Apr 13, 2025
@github-actions
Cast test env variables with dtype scope to boolean value (#2415)
2df49dd 
The PR closes #2324. It is proposes to cast test env variables with
dtype scope to boolean value which can handle empty string as a False
value. 130a24a
@antonwolfy antonwolfy added this to the 0.18.0 release milestone Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.18.0 release
Development

Successfully merging this pull request may close these issues.

Running tests with DPNP_TEST_ALL_INT_TYPES= raised an exception
3 participants
@antonwolfy @coveralls @ndgrigorian