Skip to content

remove einsum_call kwargs from dpnp.einsum_path signature #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

remove einsum_call kwargs from dpnp.einsum_path signature #2421

merged 3 commits into from
Apr 14, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 14, 2025 •
edited by antonwolfy
Loading

einsum_call is a hidden kwarg. In NumPy, it has been used internally inside einsum but it is not needed in dpnp so removing it from the signature.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Apr 14, 2025
@vtavana vtavana marked this pull request as ready for review April 14, 2025 15:56
@antonwolfy antonwolfy added this to the 0.18.0 release milestone Apr 14, 2025
antonwolfy
antonwolfy reviewed Apr 14, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2421/index.html

@coveralls
Copy link
Collaborator

coveralls commented Apr 14, 2025 •
edited
Loading

Coverage Status

coverage: 72.271%. remained the same
when pulling ce931ac on remove-einsum_call-kwargs
into 5468479 on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev1=py312he4f9c94_4 ran successfully.
Passed: 1219
Failed: 0
Skipped: 10

antonwolfy
antonwolfy reviewed Apr 14, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for handling that. Just a small comment from me, but in overall LGTM!

@vtavana vtavana merged commit 316240c into master Apr 14, 2025
67 of 68 checks passed
@vtavana vtavana deleted the remove-einsum_call-kwargs branch April 14, 2025 20:28
github-actions bot added a commit that referenced this pull request Apr 14, 2025
@github-actions
remove einsum_call kwargs from dpnp.einsum_path signature (#2421)
256ec3e 
`einsum_call` is a [hidden
kwarg](https://github.com/numpy/numpy/blob/main/numpy/_core/einsumfunc.pyi#L174).
In NumPy, it has been used internally inside `einsum` but it is not
needed in dpnp so removing it from the signature.

---------

Co-authored-by: Anton <[email protected]> 316240c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
0.18.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy