Skip to content

Pin setuptools to 79.0.1 in public CI #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2025
Merged

Pin setuptools to 79.0.1 in public CI #2434

merged 2 commits into from
May 5, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 4, 2025 •
edited
Loading

Using setuptools version from 80.0.0 has been causing a failure in the GitHub workflow where
python scripts/build_locally.py is used to build dpnp.

This PR pins setuptools to 79.0.1 for now while investigating.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this May 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 4, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 4, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev1=py312he4f9c94_14 ran successfully.
Passed: 1222
Failed: 0
Skipped: 9

@antonwolfy antonwolfy marked this pull request as ready for review May 4, 2025 22:02
@vtavana
fix failed test in test_ndarray.py (#2435)
25c80e6 
The behavior of `repr` was modified in
IntelPython/dpctl#2067.

Tests in `dpnp` should be modified to align with this new behavior.
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 72.271%. remained the same
when pulling 25c80e6 on pin-setuptools-to-below-80
into 6a81e55 on master.

@antonwolfy antonwolfy merged commit 60830e1 into master May 5, 2025
47 of 66 checks passed
@antonwolfy antonwolfy deleted the pin-setuptools-to-below-80 branch May 5, 2025 14:29
github-actions bot added a commit that referenced this pull request May 5, 2025
@github-actions
Pin setuptools to 79.0.1 in public CI (#2434)
e24828c 
Using `setuptools` version from `80.0.0` has been causing a failure in
the GitHub workflow where
`python scripts/build_locally.py` is used to build dpnp.

This PR pins `setuptools` to `79.0.1` for now while investigating. 60830e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vtavana