Implement strides for 29 element-wise functions part 4 #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/elem-wise-strides4
…ture/elem-wise-strides4
…ture/elem-wise-strides4
| template <typename _KernelNameSpecialization1, typename _KernelNameSpecialization2> \ | ||
| class __name__##_strides_kernel; \ | ||
| \ | ||
| template <typename _DataType_output, typename _DataType_input> \ |
There was a problem hiding this comment.
Why we need this renaming/switching of order of typenames in template?
template <typename _DataType_input, typename _DataType_output> -> template <typename _DataType_output, typename _DataType_input>
It looks like significant part of changes in this PR are related to this renaming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR depends on #985, #991 and #992.