update functions name #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally,
mkl_fft.rfft
andmkl_fft.irfft
were replicatingscipy.fftpack.rfft
andscipy.fftpack.irfft
. However,scipy.fftpack
module is deprecated and replaced withscipy.fft
module. And there weremkl_fft.rfft_numpy
andmkl_fft.irfft_numpy
which replicatedscipy.fft.rfft
andscipy.fft.irfft
.In this PR, name of the functions are updated to match with
scipy.fft
module (andnumpy.fft
module). This means the following changes are made:mkl_fft.rfft
andmkl_fft.irfft
are renamed tomkl_fft.rfftpack
andmkl_fft.irfftpack
, respectively.mkl_fft.rfft_numpy
,mkl_fft.irfft_numpy
,mkl_fft.rfft2_numpy
,mkl_fft.irfft2_numpy
,mkl_fft.rfftn_numpy
andmkl_fft.irfftn_numpy
are renamed tomkl_fft.rfft
,mkl_fft.irfft
,mkl_fft.rfft2
,mkl_fft.irfft2
,mkl_fft.rfftn
andmkl_fft.irfftn
, respectively. (consistent withnumpy.fft
andscipy.fft
modules)Also, file
_scipy_fft.py
is renamed to_scipy_fftpack.py
since it replicatesscipy.fftpack
module (it is not exposed throughmkl_fft.interface
and is just kept there to be used directly, if needed).In addition, file
_scipy_fft_backend.py
is renamed to_scipy_fft.py
since it replicatesscipy.fft
module (similar to file_numpy_fft.py
which replicatesnumpy.fft
module)