Skip to content

update functions name #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

update functions name #137

merged 2 commits into from
Mar 14, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Mar 13, 2025

Originally, mkl_fft.rfft and mkl_fft.irfft were replicating scipy.fftpack.rfft and scipy.fftpack.irfft. However, scipy.fftpack module is deprecated and replaced with scipy.fft module. And there were mkl_fft.rfft_numpy and mkl_fft.irfft_numpy which replicated scipy.fft.rfft and scipy.fft.irfft.

In this PR, name of the functions are updated to match with scipy.fft module (and numpy.fft module). This means the following changes are made:

  1. the original mkl_fft.rfft and mkl_fft.irfft are renamed to mkl_fft.rfftpack and mkl_fft.irfftpack, respectively.
  2. mkl_fft.rfft_numpy, mkl_fft.irfft_numpy, mkl_fft.rfft2_numpy, mkl_fft.irfft2_numpy, mkl_fft.rfftn_numpy and mkl_fft.irfftn_numpy are renamed to mkl_fft.rfft, mkl_fft.irfft, mkl_fft.rfft2, mkl_fft.irfft2, mkl_fft.rfftn and mkl_fft.irfftn, respectively. (consistent with numpy.fft and scipy.fft modules)

Also, file _scipy_fft.py is renamed to _scipy_fftpack.py since it replicates scipy.fftpack module (it is not exposed through mkl_fft.interface and is just kept there to be used directly, if needed).
In addition, file _scipy_fft_backend.py is renamed to _scipy_fft.py since it replicates scipy.fft module (similar to file _numpy_fft.py which replicates numpy.fft module)

@vtavana vtavana self-assigned this Mar 13, 2025
@vtavana vtavana marked this pull request as ready for review March 14, 2025 13:34
@vtavana vtavana merged commit 69defde into master Mar 14, 2025
40 checks passed
@vtavana vtavana deleted the update-func-name branch March 14, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants