Update code for newer NumPy #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removed use of vendored numpy.pxd, replaced it with cimport numpy to resolve runtime warning during import of change in size of broadcast struct 2. Use explicit namespace for NumPy C-API symbols imported by Cython. This caught several issues where C-API ndarray object was used where Python object of type np.ndarray was intended. 3. Resolve compilation warnings reported by Clang about ignored type qualifier during casting. Local build now passes, import does not report the runtime warning, and test suite passes.
The helper file defines workaround_PyArray_MultiIter_SIZE, etc which used NumPy 2.0 API when building with NumPy 2.0, and a work-around for earlier versions.
oleksandr-pavlyk
force-pushed
the
update-code-base-for-newer-numpy
branch
from
f6f0a68 to
9640607
Compare
antonwolfy
reviewed
Jul 26, 2024
xaleryb
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local build now passes, import does not report the runtime warning, and test suite passes.