-
Notifications
You must be signed in to change notification settings - Fork 162
Prepare 13.6.0.5 #1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 13.6.0.5 #1954
Conversation
f92ed42
to
018ded8
Compare
018ded8
to
fcbcf2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume you've already tested the migration changes, LGTM
CHANGELOG.md
Outdated
@@ -1,5 +1,13 @@ | |||
# Revision history for cardano-db-sync | |||
|
|||
## 13.6.0.5 | |||
- Fix offchain data [#1928] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this clarify that this is bumping bytesToRead
(from 10000
) and maxBytes
(from 30000
) to 300000
?
Looking at the large-ish off-chain contents floating around, there is no indication on max length on request - meaning this issue can still occur, but atleast a reference somewhere (ideally in docs instead of changelog) would help us to point to "a source"/decision.
fcbcf2b
to
21f41b9
Compare
21f41b9
to
8692f30
Compare
Description
Add your description here, if it fixes a particular issue please provide a link to the issue.
Checklist
fourmolu
on version 0.10.1.0 (which can be run withscripts/fourmolize.sh
)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.