Skip to content

Prepare 13.6.0.5 #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2025
Merged

Prepare 13.6.0.5 #1954

merged 5 commits into from
Mar 18, 2025

Conversation

kderme
Copy link
Contributor

@kderme kderme commented Mar 14, 2025

Description

Add your description here, if it fixes a particular issue please provide a link to the issue.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@kderme kderme requested review from a team as code owners March 14, 2025 18:39
@kderme kderme force-pushed the kderme/prepare-13.6.0.5 branch from f92ed42 to 018ded8 Compare March 14, 2025 19:07
@kderme kderme force-pushed the kderme/prepare-13.6.0.5 branch from 018ded8 to fcbcf2b Compare March 14, 2025 21:06
sgillespie
sgillespie previously approved these changes Mar 17, 2025
Copy link
Contributor

@sgillespie sgillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume you've already tested the migration changes, LGTM

CHANGELOG.md Outdated
@@ -1,5 +1,13 @@
# Revision history for cardano-db-sync

## 13.6.0.5
- Fix offchain data [#1928]
Copy link
Contributor

@rdlrt rdlrt Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this clarify that this is bumping bytesToRead (from 10000) and maxBytes (from 30000) to 300000?

Looking at the large-ish off-chain contents floating around, there is no indication on max length on request - meaning this issue can still occur, but atleast a reference somewhere (ideally in docs instead of changelog) would help us to point to "a source"/decision.

@kderme kderme force-pushed the kderme/prepare-13.6.0.5 branch from 21f41b9 to 8692f30 Compare March 18, 2025 14:10
@kderme kderme merged commit cb61094 into master Mar 18, 2025
7 of 18 checks passed
@kderme kderme deleted the kderme/prepare-13.6.0.5 branch March 21, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants