Remove complexity #42
Conversation
There was a problem hiding this comment.
I understand you want to reduce the complexity of SequenceMatcher, but imho this is the other way around.
Now you're extending a helper class with a base class, instead of the base class making use of a helper class. I think it's better to keep them separately and call the methods of the helper class when needed.
Since the methods in the SequenceMatcherHelper are independent you can declare them as static so you don't have to instantiate this class to make use of them.
When the methods are static, you can use them for any other class and the name SequenceMatcherHelper could be renamed to something more generic like Utils.
To use them in SequenceMatcher, you call them like Utils::methodName(arguments) (Assuming you've imported the correct namespaces).
SequenceMatcherHelper::arrayGetDefault() is redundant to the null coalesce operator.
$myArray = ['a', 'b', 'c'];
$aValue = SequenceMatcherHelper->arrayGetDefault($myArray, 1, 'Oops')is the same as
$myArray = ['a', 'b', 'c'];
$aValue = $myArray[1] ?? 'Oops';
|
Go for it. Make a change and open a PR. I'm happy to merge it. |
- Removed redundant method SequenceMatcherHelper::arrayGetDefault(). - Renamed SequenceMatcherHelper to more generic name DiffUtils. - Changed calls to SequenceMatcherHelper::arrayGetDefault() into comparison with null coalesce operator. - Moved helper class from renderer directory to Diff directory. - Changed namespaces to reflect above changes.
No description provided.