perf: optimize walk method by 10-34% #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The walk method now only takes the parameters it actually needs, which gives a performance bump to due to less copying & passing of parameters to the walk method. Running json-querying-performance-testing, this change produced the following speed improvements compared to v7.1.0. ``` smallCityLots ┌───────────────┬───────────┬────────────┬─────────────┐ │ (index) │ shallow │ deep │ conditional │ ├───────────────┼───────────┼────────────┼─────────────┤ │ jsonpath-plus │ 0.0641 │ 0.3249 │ 0.1199 │ ├───────────────┼───────────┼────────────┼─────────────┤ │ jsonpath-pr │ 0.0439 │ 0.2930 │ 0.0850 │ ├───────────────┼───────────┼────────────┼─────────────┤ │ Time Delta │ -0.0202 │ -0.0319 │ -0.0349 │ ├───────────────┼───────────┼────────────┼─────────────┤ │ % Change │ -31.5133% │ -9.8184% │ -29.1076% │ └───────────────┴───────────┴────────────┴─────────────┘ mediumCityLots ┌───────────────┬───────────┬────────────┬─────────────┐ │ (index) │ shallow │ deep │ conditional │ ├───────────────┼───────────┼────────────┼─────────────┤ │ jsonpath-plus │ 0.092 │ 0.6739 │ 0.2409 │ ├───────────────┼───────────┼────────────┼─────────────┤ │ jsonpath-pr │ 0.0659 │ 0.5443 │ 0.1672 │ ├───────────────┼───────────┼────────────┼─────────────┤ │ Time Delta │ -0.0261 │ -0.1296 │ -0.0737 │ ├───────────────┼───────────┼────────────┼─────────────┤ │ % Change │ -28.3696% │ -19.2313% │ -30.5936% │ └───────────────┴───────────┴────────────┴─────────────┘ largeCityLots ┌───────────────┬───────────┬────────────┬─────────────┐ │ (index) │ shallow │ deep │ conditional │ ├───────────────┼───────────┼────────────┼─────────────┤ │ jsonpath-plus │ 0.1910 │ 1.8946 │ 0.4900 │ ├───────────────┼───────────┼────────────┼─────────────┤ │ jsonpath-pr │ 0.1347 │ 1.6538 │ 0.3230 │ ├───────────────┼───────────┼────────────┼─────────────┤ │ Time Delta │ 0.0563 │ -0.2408 │ -0.1670 │ ├───────────────┼───────────┼────────────┼─────────────┤ │ % Change │ -29.4764% │ -12.7098% │ -34.0816% │ └───────────────┴───────────┴────────────┴─────────────┘ ```
|
@brettz9 Once this is approved & merged I would appreciate if you could cut a new release. |
jacobroschen
changed the title
|
Go ahead and merge if you have no further last minute changes. I can then look to release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The walk method now only takes the parameters it actually needs, which
gives a performance bump to due to less copying & passing of parameters
to the walk method.
Running json-querying-performance-testing, this change produced the
following speed improvements compared to v7.1.0.
PR description
Checklist
npm test, ensuring linting passes