Added a setting to show File annotations' tab only when the PDF actually contains highlights or comments #13279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… show the file annotation tab when annotations are not present in the entry files.
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| @@ -161,6 +164,18 @@ public void setShouldShowLatexCitationsTab(boolean shouldShowLatexCitationsTab) | |||
| this.shouldShowLatexCitationsTab.set(shouldShowLatexCitationsTab); | |||
| } | |||
|
|
|||
| public boolean shouldShowFileAnnotationsTab() { | |||
There was a problem hiding this comment.
The method should return an Optional instead of a primitive boolean to avoid returning null and adhere to modern Java practices.
There was a problem hiding this comment.
is that really necessary?I don't think it could ever return a null value
There was a problem hiding this comment.
Take the comments with a grain of salt. In this case the bot is wrong
Comment on lines
+29
to
+30
| public FileAnnotationTab(StateManager stateManager, | ||
| GuiPreferences preferences) { |
There was a problem hiding this comment.
The constructor should not allow null values for 'stateManager' and 'preferences'. Consider using JSpecify @nonnull annotations to enforce non-null parameters.
There was a problem hiding this comment.
is that really necessary?
Siedlerchr
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13143
added a checkbox as described in the issue to not show the file annotation tab when annotations are not present in the entry files.
Steps to test
Screen.Recording.2025-06-08.at.18.25.17.mov
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)