Skip to content

Fixing unable to commit problem #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eramitmittal
Copy link

Commit was not working at all with VsCode 1.18.0.
(Didn't test with an older version)

Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @eramitmittal

The only issue i have with the PR is that it limits the amount you can commit to one file. The original idea behind this was to allow one or several files to be committed.

@JohnstonCode
Copy link
Owner

Ignore me. I see what your doing now.

Thanks alot for fixing this,

@JohnstonCode JohnstonCode merged commit 4834ffe into JohnstonCode:master Nov 18, 2017
@eramitmittal eramitmittal deleted the fix_for_commit_problem branch November 18, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants