Skip to content

Fix trying to open every file as a repo (close #621) #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

dbausch
Copy link
Contributor

@dbausch dbausch commented Jun 29, 2019

The code missed an "await" at the place where the new isSvnFolder
function is used. Function isSvnFolder always returns a valid
Promise, which was treated like a boolean "true" in the "if".

The code missed an "await" at the place where the new isSvnFolder
function is used.  Function isSvnFolder always returns a valid
Promise, which was treated like a boolean "true" in the "if".
@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #625 into master will decrease coverage by 0.63%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   57.12%   56.49%   -0.64%     
==========================================
  Files         117      117              
  Lines        4397     4397              
  Branches      646      634      -12     
==========================================
- Hits         2512     2484      -28     
- Misses       1651     1673      +22     
- Partials      234      240       +6
Impacted Files Coverage Δ
src/model.ts 60.25% <100%> (ø) ⬆️
src/svnFinder.ts 62.71% <0%> (-16.95%) ⬇️
src/svnError.ts 55.55% <0%> (-16.67%) ⬇️
src/util.ts 73.78% <0%> (-5.83%) ⬇️
src/svn.ts 77.98% <0%> (-3.67%) ⬇️
src/commands/command.ts 50% <0%> (-1.5%) ⬇️
src/repository.ts 60.13% <0%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629df3c...d6e7298. Read the comment docs.

Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnstonCode JohnstonCode merged commit 4d45079 into JohnstonCode:master Jul 1, 2019
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 1.54.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants