Skip to content

Use Aqua for project quality checks #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 9, 2022
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 8, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 32.35% // Head: 17.36% // Decreases project coverage by -14.99% ⚠️

Coverage data is based on head (4f448bc) compared to base (3975a6a).
Patch coverage: 16.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #197       +/-   ##
===========================================
- Coverage   32.35%   17.36%   -15.00%     
===========================================
  Files          77       77               
  Lines        7912     7890       -22     
===========================================
- Hits         2560     1370     -1190     
- Misses       5352     6520     +1168     
Impacted Files Coverage Δ
src/ApproxFunBase.jl 66.66% <ø> (ø)
src/Domain.jl 39.68% <ø> (-17.47%) ⬇️
src/Multivariate/TensorSpace.jl 8.00% <0.00%> (-2.00%) ⬇️
src/Operators/Operator.jl 24.93% <ø> (-16.63%) ⬇️
src/Operators/systems.jl 0.00% <0.00%> (ø)
src/PDE/PDE.jl 0.00% <ø> (ø)
src/Operators/SubOperator.jl 16.23% <100.00%> (-22.32%) ⬇️
src/onehotvector.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Operators/general/PartialInverseOperator.jl 0.00% <0.00%> (-96.43%) ⬇️
src/LinearAlgebra/standardchop.jl 0.00% <0.00%> (-91.49%) ⬇️
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub closed this Sep 8, 2022
@jishnub jishnub reopened this Sep 8, 2022
@jishnub
Copy link
Member Author

jishnub commented Sep 9, 2022

Coverage reduction is because I've moved tests from here to ApproxFunOrthogonalPolynomials to avoid circular dependency (JuliaApproximation/ApproxFunOrthogonalPolynomials.jl#104). Since we include downstream tests in computing coverage, this should catch up after versions are bumped downstream.

@jishnub jishnub merged commit 1561361 into JuliaApproximation:master Sep 9, 2022
@jishnub jishnub deleted the aqua branch September 9, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant