Skip to content

reduce(max instead of maximum #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 27, 2022

maximum with init isn't defined on v1.5, so this PR works around it.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 70.05% // Head: 70.68% // Increases project coverage by +0.62% 🎉

Coverage data is based on head (e1a1818) compared to base (abed5ff).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   70.05%   70.68%   +0.62%     
==========================================
  Files          77       77              
  Lines        8005     8005              
==========================================
+ Hits         5608     5658      +50     
+ Misses       2397     2347      -50     
Impacted Files Coverage Δ
src/Multivariate/TensorSpace.jl 67.01% <50.00%> (+1.73%) ⬆️
src/LinearAlgebra/clenshaw.jl 39.47% <0.00%> (+0.52%) ⬆️
src/Operators/Operator.jl 68.90% <0.00%> (+0.80%) ⬆️
src/Space.jl 86.93% <0.00%> (+0.90%) ⬆️
src/Domain.jl 78.12% <0.00%> (+1.56%) ⬆️
src/Multivariate/Multivariate.jl 35.41% <0.00%> (+2.08%) ⬆️
src/Multivariate/LowRankFun.jl 66.53% <0.00%> (+2.36%) ⬆️
src/PDE/PDE.jl 74.19% <0.00%> (+3.22%) ⬆️
src/Spaces/ArraySpace.jl 70.00% <0.00%> (+3.33%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 36fa310 into JuliaApproximation:master Sep 27, 2022
@jishnub jishnub deleted the maximumfix branch September 27, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant