Skip to content

Fix multiplication of MultivariateFun #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 29, 2022

After this

julia> f = (x,y)->x^2 * y^3
#983 (generic function with 1 method)

julia> L = LowRankFun(f, Chebyshev()  Chebyshev())
LowRankFun on Chebyshev()Chebyshev() of rank 1.

julia> (L^2)(0.1, 0.2)  (L * L)(0.1, 0.2)
true

julia> P = ProductFun(f, Chebyshev()Chebyshev())
ProductFun on Chebyshev()Chebyshev()

julia> (L * P)(0.1, 0.2)  (P * L)(0.1, 0.2)  (L^2)(0.1, 0.2)
true

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 69.40% // Head: 71.14% // Increases project coverage by +1.73% 🎉

Coverage data is based on head (8f9f88a) compared to base (b3f1a79).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   69.40%   71.14%   +1.73%     
==========================================
  Files          77       77              
  Lines        8007     8015       +8     
==========================================
+ Hits         5557     5702     +145     
+ Misses       2450     2313     -137     
Impacted Files Coverage Δ
src/Multivariate/LowRankFun.jl 66.01% <0.00%> (+1.84%) ⬆️
src/Multivariate/Multivariate.jl 34.00% <0.00%> (+0.66%) ⬆️
src/Multivariate/ProductFun.jl 37.50% <0.00%> (+14.08%) ⬆️
src/Operators/general/algebra.jl 91.34% <0.00%> (+0.29%) ⬆️
src/Fun.jl 69.28% <0.00%> (+0.34%) ⬆️
src/LinearAlgebra/clenshaw.jl 39.47% <0.00%> (+0.52%) ⬆️
src/Caching/blockbanded.jl 81.67% <0.00%> (+0.76%) ⬆️
src/Spaces/DiracSpace.jl 71.18% <0.00%> (+0.84%) ⬆️
src/Operators/general/CachedOperator.jl 66.10% <0.00%> (+1.69%) ⬆️
src/Space.jl 86.93% <0.00%> (+1.80%) ⬆️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit d26f787 into JuliaApproximation:master Sep 29, 2022
@jishnub jishnub deleted the prodlowrankmul branch September 29, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant