Skip to content

static splat dispatch in default_Fun #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 30, 2022

Use Val instances instead of types for dispatch in default_Fun. Also, prepare to move docstrings to ApproxFun

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 71.44% // Head: 69.30% // Decreases project coverage by -2.14% ⚠️

Coverage data is based on head (29ef597) compared to base (76d6c3f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   71.44%   69.30%   -2.15%     
==========================================
  Files          77       77              
  Lines        8020     8020              
==========================================
- Hits         5730     5558     -172     
- Misses       2290     2462     +172     
Impacted Files Coverage Δ
src/Multivariate/LowRankFun.jl 68.35% <ø> (-0.79%) ⬇️
src/Operators/general/PartialInverseOperator.jl 98.21% <ø> (ø)
src/constructors.jl 79.78% <100.00%> (-1.07%) ⬇️
src/Caching/matrix.jl 42.39% <0.00%> (-27.18%) ⬇️
src/Multivariate/VectorFun.jl 58.33% <0.00%> (-14.59%) ⬇️
src/Caching/almostbanded.jl 83.85% <0.00%> (-14.04%) ⬇️
src/LinearAlgebra/clenshaw.jl 26.84% <0.00%> (-12.64%) ⬇️
src/show.jl 76.00% <0.00%> (-7.21%) ⬇️
src/Operators/almostbanded/LowRankOperator.jl 76.19% <0.00%> (-7.15%) ⬇️
src/Operators/almostbanded/LowRankPertOperator.jl 56.66% <0.00%> (-6.67%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 9447c21 into JuliaApproximation:master Sep 30, 2022
@jishnub jishnub deleted the defaultfun branch September 30, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant