Skip to content

ProductSpace domain type fix #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 21, 2023

After this,

julia> f = Fun();

julia> P = ProductFun([f, f, f], space(f));

julia> typeof(domain(P)) == ApproxFunBase.domaintype(space(P))
true

@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Base: 71.90% // Head: 71.97% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (f562a84) compared to base (5da41bb).
Patch coverage: 86.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   71.90%   71.97%   +0.06%     
==========================================
  Files          79       79              
  Lines        8301     8311      +10     
==========================================
+ Hits         5969     5982      +13     
+ Misses       2332     2329       -3     
Impacted Files Coverage Δ
src/Spaces/SumSpace.jl 71.31% <33.33%> (ø)
src/LinearAlgebra/helper.jl 64.23% <100.00%> (+0.08%) ⬆️
src/Multivariate/TensorSpace.jl 87.50% <100.00%> (+1.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 6b777fe into JuliaApproximation:master Jan 22, 2023
@jishnub jishnub deleted the prodspacedomain branch January 22, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant