Skip to content

Improve inference in blockintercer iteration #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 22, 2023

On master

julia> s = Fourier();

julia> b = ApproxFunBase.BlockInterlacer(s);

julia> @btime first($b, 10);
  6.564 μs (124 allocations: 6.95 KiB)

This PR

julia> @btime first($b, 10);
  1.103 μs (28 allocations: 2.31 KiB)

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Base: 71.97% // Head: 71.97% // No change to project coverage 👍

Coverage data is based on head (41f28aa) compared to base (6b777fe).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   71.97%   71.97%           
=======================================
  Files          79       79           
  Lines        8311     8311           
=======================================
  Hits         5982     5982           
  Misses       2329     2329           
Impacted Files Coverage Δ
src/LinearAlgebra/helper.jl 64.23% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 17d6057 into JuliaApproximation:master Jan 22, 2023
@jishnub jishnub deleted the blockinterlaceriter branch January 22, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant