Skip to content

Bandwidths tuple in view #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 24, 2023

Using bandwidths(A::Operator) directly instead of bandwidth(A,1), bandwidth(A,2) helps with type inference.

Tests are a bit unfortunate, as the exact types need to be specified in @inferred.

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 71.98% // Head: 70.68% // Decreases project coverage by -1.31% ⚠️

Coverage data is based on head (b60ae3a) compared to base (6e231f8).
Patch coverage: 96.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   71.98%   70.68%   -1.31%     
==========================================
  Files          79       79              
  Lines        8311     8320       +9     
==========================================
- Hits         5983     5881     -102     
- Misses       2328     2439     +111     
Impacted Files Coverage Δ
src/Multivariate/TrivialTensorFun.jl 96.00% <ø> (ø)
src/Operators/SubOperator.jl 83.16% <88.88%> (+0.16%) ⬆️
src/ApproxFunBase.jl 83.33% <100.00%> (+2.38%) ⬆️
src/LinearAlgebra/helper.jl 64.93% <100.00%> (+0.69%) ⬆️
src/Multivariate/TensorSpace.jl 86.70% <100.00%> (-0.80%) ⬇️
src/Operators/banded/CalculusOperator.jl 76.14% <100.00%> (-2.56%) ⬇️
src/PDE/KroneckerOperator.jl 79.60% <100.00%> (ø)
src/Domains/UnionDomain.jl 51.06% <0.00%> (-23.41%) ⬇️
src/Operators/almostbanded/LowRankOperator.jl 71.42% <0.00%> (-11.91%) ⬇️
src/Spaces/ProductSpaceOperators.jl 64.84% <0.00%> (-7.28%) ⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 70cd5d2 into JuliaApproximation:master Jan 24, 2023
@jishnub jishnub deleted the bandwidthstuple branch January 24, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant