Skip to content

Type-stability in 2d tensorizer iteration #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 26, 2023

On master

julia> t = ApproxFunBase.tensorizer(Chebyshev()^2);

julia> @btime first(ApproxFunBase.cache($t), 100);
  26.686 μs (702 allocations: 58.25 KiB)

This PR

julia> @btime first(ApproxFunBase.cache($t), 100);
  16.425 μs (502 allocations: 47.31 KiB)

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 71.39% // Head: 72.14% // Increases project coverage by +0.75% 🎉

Coverage data is based on head (acf6120) compared to base (fea3939).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   71.39%   72.14%   +0.75%     
==========================================
  Files          79       79              
  Lines        8323     8314       -9     
==========================================
+ Hits         5942     5998      +56     
+ Misses       2381     2316      -65     
Impacted Files Coverage Δ
src/LinearAlgebra/helper.jl 66.04% <100.00%> (+1.34%) ⬆️
src/Multivariate/TensorSpace.jl 87.91% <100.00%> (+0.93%) ⬆️
src/Operators/general/InterlaceOperator.jl 86.36% <0.00%> (+0.34%) ⬆️
src/Caching/almostbanded.jl 97.89% <0.00%> (+0.35%) ⬆️
src/PDE/KroneckerOperator.jl 79.60% <0.00%> (+0.39%) ⬆️
src/Space.jl 86.08% <0.00%> (+0.43%) ⬆️
src/LinearAlgebra/clenshaw.jl 39.47% <0.00%> (+0.52%) ⬆️
src/show.jl 98.47% <0.00%> (+0.76%) ⬆️
src/Multivariate/LowRankFun.jl 68.70% <0.00%> (+0.76%) ⬆️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 93e79dd into JuliaApproximation:master Jan 26, 2023
@jishnub jishnub deleted the tensorizeriter branch January 26, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant