Skip to content

Disable empty vector in findmindomain/findmaxrange #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 30, 2023

This improves type inference by some extent, as the result may be inferrable. This is an internal method, so the change should be ok.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 71.39% // Head: 70.75% // Decreases project coverage by -0.64% ⚠️

Coverage data is based on head (3560466) compared to base (fea3939).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   71.39%   70.75%   -0.64%     
==========================================
  Files          79       79              
  Lines        8323     8313      -10     
==========================================
- Hits         5942     5882      -60     
- Misses       2381     2431      +50     
Impacted Files Coverage Δ
src/LinearAlgebra/helper.jl 66.04% <100.00%> (+1.34%) ⬆️
src/Multivariate/TensorSpace.jl 86.53% <100.00%> (-0.45%) ⬇️
src/Operators/general/InterlaceOperator.jl 86.36% <100.00%> (+0.34%) ⬆️
src/Operators/general/algebra.jl 92.47% <100.00%> (-0.28%) ⬇️
src/Operators/spacepromotion.jl 66.19% <100.00%> (+1.40%) ⬆️
src/Domains/UnionDomain.jl 51.06% <0.00%> (-23.41%) ⬇️
src/Operators/almostbanded/LowRankOperator.jl 71.42% <0.00%> (-11.91%) ⬇️
src/Spaces/Spaces.jl 58.75% <0.00%> (-6.69%) ⬇️
src/specialfunctions.jl 61.18% <0.00%> (-5.93%) ⬇️
src/Spaces/ProductSpaceOperators.jl 64.84% <0.00%> (-5.46%) ⬇️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit d8c68be into JuliaApproximation:master Jan 30, 2023
@jishnub jishnub deleted the findmindomain_nonempty branch January 30, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant