Skip to content

Precompute bandwidth in sumspace deriv #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 16, 2023

After this, the following becomes type-stable:

julia> @inferred Derivative(Chebyshev()+Legendre())
DerivativeWrapper : Chebyshev()  Legendre()  Ultraspherical(1)  Jacobi(1,1)
 0.0  0.0  1.0                              
     0.0  0.0  1.0                          
         0.0  0.0  2.0                      
             0.0  0.0  1.5                  
                 0.0  0.0  3.0              
                     0.0  0.0  2.0          
                         0.0  0.0  4.0      
                             0.0  0.0  2.5  
                                 0.0  0.0  
                                     0.0  
                                         

julia> @inferred Derivative(Chebyshev(0..1) + Legendre(1..2))
DerivativeWrapper : Chebyshev(0..1) ⨄ Legendre(1..2)  Ultraspherical(1,0..1)  Jacobi(1,1,1..2)
 0.0  0.0  2.0                              
     0.0  0.0  2.0                          
         0.0  0.0  4.0                      
             0.0  0.0  3.0                  
                 0.0  0.0  6.0              
                     0.0  0.0  4.0          
                         0.0  0.0  8.0      
                             0.0  0.0  5.0  
                                 0.0  0.0  
                                     0.0  
                                         

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 95.12% and project coverage change: +3.02 🎉

Comparison is base (8dbc982) 68.19% compared to head (7a3949c) 71.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   68.19%   71.21%   +3.02%     
==========================================
  Files          80       80              
  Lines        8424     8471      +47     
==========================================
+ Hits         5745     6033     +288     
+ Misses       2679     2438     -241     
Impacted Files Coverage Δ
src/ApproxFunBase.jl 83.33% <ø> (+12.50%) ⬆️
src/Operators/Operator.jl 67.02% <83.33%> (+1.76%) ⬆️
src/Operators/general/InterlaceOperator.jl 87.06% <100.00%> (+2.17%) ⬆️
src/Spaces/ProductSpaceOperators.jl 69.88% <100.00%> (-3.22%) ⬇️
src/show.jl 97.70% <100.00%> (+6.10%) ⬆️

... and 40 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub changed the title constant prop in sumspace deriv Precompute bandwidth in sumspace deriv Mar 19, 2023
jishnub added 2 commits March 20, 2023 16:01
pass sumspace deriv bandwidth to interlaceop

version bump to v0.8.5

bandwidth for piecewise derivative

fix rangespace for PiecewiseSpace

multiplication
@jishnub jishnub closed this Mar 26, 2023
@jishnub jishnub deleted the sumspacederiv branch June 7, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant