Skip to content

parameterize almostbandedmatrix #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 23, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 23, 2023

Fix

julia> @inferred (B -> B.bands)(ApproxFunBase.AlmostBandedMatrix{Float64}(Zeros(4,4), (1,1), 2))
ERROR: return type BandedMatrices.BandedMatrix{Float64, Matrix{Float64}, Base.OneTo{Int64}} does not match inferred return type BandedMatrices.BandedMatrix{Float64}
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] top-level scope
   @ REPL[9]:1

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -5.68 ⚠️

Comparison is base (19fb052) 68.29% compared to head (6c1010f) 62.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   68.29%   62.61%   -5.68%     
==========================================
  Files          80       80              
  Lines        8463     8483      +20     
==========================================
- Hits         5780     5312     -468     
- Misses       2683     3171     +488     
Impacted Files Coverage Δ
src/Caching/almostbanded.jl 95.08% <100.00%> (-2.81%) ⬇️
src/LinearAlgebra/AlmostBandedMatrix.jl 90.00% <100.00%> (-0.48%) ⬇️

... and 59 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 7ff2f2b into JuliaApproximation:master Mar 23, 2023
@jishnub jishnub deleted the almostbanded branch March 23, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant