Skip to content

UndefError fix (JuliaApproximation/ApproxFunBase.jl#701) #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2020
Merged

UndefError fix (JuliaApproximation/ApproxFunBase.jl#701) #42

merged 3 commits into from
Apr 28, 2020

Conversation

Gyoshi
Copy link
Contributor

@Gyoshi Gyoshi commented Apr 26, 2020

No description provided.

@Gyoshi Gyoshi changed the title UndefError fix (#701) UndefError fix (JuliaApproximation/ApproxFunBase.jl#701) Apr 26, 2020
dlfivefifty
dlfivefifty reviewed Apr 26, 2020
View reviewed changes
Copy link
Member

@dlfivefifty dlfivefifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does fixing the typo k -> i also fix this?

@Gyoshi
Copy link
Contributor Author

Gyoshi commented Apr 26, 2020

Nope, changing k -> i and D -> A leaves a method ambiguity error for rowstop(D::TimesOperator, i::Infinity)

@dlfivefifty
Copy link
Member

Ok can you leave your fix but add the alternative as a comment? This may help future bugs

@dlfivefifty
Copy link
Member

Can you bump the patch version too?

@dlfivefifty dlfivefifty merged commit 414710f into JuliaApproximation:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlfivefifty dlfivefifty dlfivefifty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gyoshi @dlfivefifty