Skip to content

Fix space promotion in timesoperator #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Apr 25, 2023

After this, the following works:

julia> X = Multiplication(Fun(Legendre()), NormalizedLegendre())  Jacobi(2,2)
TimesOperator : NormalizedLegendre()  Jacobi(2,2)
 0.0       0.174964  0.0          -0.178174    0.0         0.0507621                                              
 0.235702  0.0       3.15416e-17   0.0        -0.149992    0.0         0.0594291                                   
          0.174964  0.0          -0.0364447   0.0        -0.140572    0.0         0.067029                         
                   0.158114      0.0        -0.0543928   0.0        -0.137281    0.0         0.0738763             
                                0.151178    0.0        -0.0663291   0.0        -0.136687    0.0         0.0801565  
                                           0.148344    0.0        -0.07551     0.0        -0.137477    0.0        
                                                      0.1476      0.0        -0.0831563   0.0        -0.139047   
                                                                 0.148048    0.0        -0.0898326   0.0        
                                                                            0.149225    0.0        -0.0958393  
                                                                                       0.150867    0.0        
                                                                                                            

julia> Y = X : Legendre()
TimesOperator : Legendre()  Jacobi(2,2)
 0.0       0.142857   0.0          -0.0952381   0.0         0.021645                                               
 0.333333  0.0       -6.16791e-19   0.0        -0.0707071   0.0         0.02331                                     
          0.142857   0.0          -0.0194805   0.0        -0.0599401   0.0         0.0244755                        
                    0.1           0.0        -0.025641    0.0        -0.0538462   0.0         0.0253394             
                                 0.0808081   0.0        -0.0282828   0.0        -0.0499109   0.0         0.0260062  
                                            0.0699301   0.0        -0.0296174   0.0        -0.0471541   0.0        
                                                       0.0629371   0.0        -0.0303644   0.0        -0.0451128  
                                                                  0.0580694   0.0        -0.0308123   0.0        
                                                                             0.0544892   0.0        -0.0310944  
                                                                                        0.051747    0.0        
                                                                                                             

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: +7.98 🎉

Comparison is base (bf0f889) 63.24% compared to head (f5d4945) 71.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   63.24%   71.22%   +7.98%     
==========================================
  Files          80       80              
  Lines        8315     8331      +16     
==========================================
+ Hits         5259     5934     +675     
+ Misses       3056     2397     -659     
Impacted Files Coverage Δ
src/Operators/functionals/Evaluation.jl 88.04% <90.62%> (+6.79%) ⬆️
src/Fun.jl 69.15% <100.00%> (+8.13%) ⬆️
src/Operators/general/algebra.jl 92.02% <100.00%> (+1.35%) ⬆️
src/Space.jl 85.47% <100.00%> (+6.56%) ⬆️
src/show.jl 82.83% <100.00%> (-10.30%) ⬇️

... and 50 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 2f401fa into JuliaApproximation:master Apr 25, 2023
@jishnub jishnub deleted the spacepromotion branch April 25, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant