Skip to content

traits in size/bandwidths in wrapperstructure #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 15, 2023

The goal is to move wrapper structures, wrapped indexing and similar properties to traits. This vastly reduces the number of methods that we need to define.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 86.66% and project coverage change: +0.04 🎉

Comparison is base (6f0cf81) 70.54% compared to head (3e1f90d) 70.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
+ Coverage   70.54%   70.58%   +0.04%     
==========================================
  Files          81       81              
  Lines        8477     8509      +32     
==========================================
+ Hits         5980     6006      +26     
- Misses       2497     2503       +6     
Impacted Files Coverage Δ
src/ApproxFunBase.jl 84.00% <ø> (ø)
src/Operators/banded/CalculusOperator.jl 74.19% <0.00%> (-1.22%) ⬇️
src/Operators/banded/ConstantOperator.jl 78.65% <ø> (-1.35%) ⬇️
src/Operators/functionals/CalculusFunctional.jl 76.74% <50.00%> (-2.75%) ⬇️
src/Operators/Operator.jl 73.44% <90.24%> (+1.18%) ⬆️
src/Operators/functionals/Evaluation.jl 88.17% <100.00%> (+0.12%) ⬆️
src/Operators/spacepromotion.jl 62.50% <100.00%> (+0.52%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit 1a9877e into JuliaApproximation:master Jun 27, 2023
@jishnub jishnub deleted the traits branch June 27, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant