Skip to content

Reduce allocations in symmetric eigen #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 4, 2023

ω = 25.0
d = -10..10;
S = Legendre(d);
V = Fun(x -> ω * x^2 + x^4, S)
L = -Derivative(S, 2) + V;
B = Dirichlet(S);
SE = ApproxFun.SymmetricEigensystem(L, B);

Using this,

julia> @btime ApproxFunBase.bandmatrices_eigen($SE, 100);
  3.108 ms (6871 allocations: 1.50 MiB) # master
  3.027 ms (6427 allocations: 1.48 MiB) # PR

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 16.66% and no project coverage change.

Comparison is base (27c3236) 27.41% compared to head (1bd5c52) 27.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #532   +/-   ##
=======================================
  Coverage   27.41%   27.42%           
=======================================
  Files          80       80           
  Lines        8363     8366    +3     
=======================================
+ Hits         2293     2294    +1     
- Misses       6070     6072    +2     
Files Changed Coverage Δ
src/eigen.jl 0.00% <0.00%> (ø)
src/Spaces/QuotientSpace.jl 3.95% <28.57%> (+0.50%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 7b2081d into JuliaApproximation:master Aug 4, 2023
@jishnub jishnub deleted the eigenallocs branch August 4, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant