Skip to content

Fix show for Fun in an ArraySpace #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 11, 2023

This removes the show method for Fun{<:Union{ConstantSpace, ArraySpace{<:ConstantSpace}}}, as the special cases were becoming unwieldy to maintain

Fixes the display for

julia> D2 = Dirichlet(Chebyshev(),1);

julia> D2 * Fun()
Fun(ApproxFunBase.ArraySpace(ConstantSpace{Point{Float64}, Float64}[ConstantSpace(Point(-1.0)), ConstantSpace(Point(1.0))]), [1.0])

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: -0.10% ⚠️

Comparison is base (614f040) 27.62% compared to head (ff2e6d6) 27.53%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   27.62%   27.53%   -0.10%     
==========================================
  Files          80       80              
  Lines        8387     8379       -8     
==========================================
- Hits         2317     2307      -10     
- Misses       6070     6072       +2     
Files Changed Coverage Δ
src/Operators/SubOperator.jl 42.64% <25.00%> (ø)
src/Operators/functionals/Evaluation.jl 43.47% <100.00%> (ø)
src/show.jl 62.96% <100.00%> (-3.42%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit c6f4c50 into JuliaApproximation:master Aug 11, 2023
@jishnub jishnub deleted the showconst branch August 11, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant