Skip to content

Improve type-inference in multiplying with TimesOperator #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 6, 2023

This makes the following type-inferred:

julia> M = Multiplication(Fun(),Chebyshev());

julia> @inferred M * M * M
TimesOperator : Chebyshev()  Chebyshev()
 0.0   0.375  0.0    0.125                                      
 0.75  0.0    0.5    0.0    0.125                                
 0.0   0.5    0.0    0.375  0.0    0.125                          
 0.25  0.0    0.375  0.0    0.375  0.0    0.125                    
      0.125  0.0    0.375  0.0    0.375  0.0    0.125              
            0.125  0.0    0.375  0.0    0.375  0.0    0.125        
                  0.125  0.0    0.375  0.0    0.375  0.0    0.125  
                        0.125  0.0    0.375  0.0    0.375  0.0    
                              0.125  0.0    0.375  0.0    0.375  
                                    0.125  0.0    0.375  0.0    
                                                            

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: +13.38% 🎉

Comparison is base (5bfe08f) 57.83% compared to head (d277c3a) 71.22%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #587       +/-   ##
===========================================
+ Coverage   57.83%   71.22%   +13.38%     
===========================================
  Files          80       80               
  Lines        8330     8381       +51     
===========================================
+ Hits         4818     5969     +1151     
+ Misses       3512     2412     -1100     
Files Changed Coverage Δ
src/Operators/general/algebra.jl 88.15% <87.50%> (+4.91%) ⬆️
src/Operators/banded/Multiplication.jl 77.77% <100.00%> (+2.46%) ⬆️

... and 55 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 5ceec43 into JuliaApproximation:master Sep 6, 2023
@jishnub jishnub deleted the timesopmul branch September 6, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant